Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status param override for products stream #59

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

dmosorast
Copy link
Contributor

@dmosorast dmosorast commented Jul 31, 2020

Description of change

It appears that Shopify has changed the parameter key from status to published_status for Products. This is currently resulting in 0 products being returned due to an implied bug on Shopify's end.

This PR makes this request parameter configurable, and implements an override for the products stream.

Given that their documentation for the tap's version of the Products endpoint now lists published_status, this seems like a much safer change

QA steps

  • manual qa steps passing (list below)
    • Ran through other streams to ensure that they were still getting records back
    • Ran through products with the old key of status and the new key published_status and confirmed that this gets that stream moving again.

Risks

Medium-Low, effect on other streams should be minimal. However, this is a workaround for a Shopify issue, so it's slightly risky given that this changed without warning across all API versions.

Rollback steps

  • revert this branch and release new patch version

@dmosorast dmosorast merged commit efd35c1 into master Jul 31, 2020
@dmosorast dmosorast deleted the fix/add-status-override-for-products branch July 31, 2020 17:36
@dmosorast dmosorast mentioned this pull request Jul 31, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants