Add status param override for products stream #59
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
It appears that Shopify has changed the parameter key from
status
topublished_status
for Products. This is currently resulting in 0 products being returned due to an implied bug on Shopify's end.This PR makes this request parameter configurable, and implements an override for the
products
stream.Given that their documentation for the tap's version of the Products endpoint now lists
published_status
, this seems like a much safer changeQA steps
status
and the new keypublished_status
and confirmed that this gets that stream moving again.Risks
Medium-Low, effect on other streams should be minimal. However, this is a workaround for a Shopify issue, so it's slightly risky given that this changed without warning across all API versions.
Rollback steps