Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update schema to allow Shopify to send us poorly formatted line_item #58

Merged
merged 3 commits into from
Jul 16, 2020
Merged

Update schema to allow Shopify to send us poorly formatted line_item #58

merged 3 commits into from
Jul 16, 2020

Conversation

cosimon
Copy link
Contributor

@cosimon cosimon commented Jul 16, 2020

Description of change

Shopify sometimes sends line_item as an empty dictionary instead of an empty list.

QA steps

  • automated tests passing
  • manual qa steps passing (list below)
    Ran the tap on a connection that was failing previously due to schema mismatch. It now succeeds.

Risks

Low - Adding an anyOf should not affect previous behavior and should only allow this

Rollback steps

  • revert this branch

@KAllan357 KAllan357 merged commit d6a8e90 into master Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KAllan357 KAllan357 KAllan357 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cosimon @KAllan357