Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to API version 2019-10 and bump SDK version to latest #54

Merged
merged 3 commits into from
Mar 24, 2020

Conversation

dmosorast
Copy link
Contributor

@dmosorast dmosorast commented Mar 23, 2020

Description of change

Upgrading Shopify API used by the tap to a more recent version.

https://stitchdata.atlassian.net/browse/SRCE-2556

QA steps

  • automated tests passing
  • manual qa steps passing (list below)
    • Ran through manual syncs and confirmed that since_id is still behaving the way that it is expected to, with all bumps to versions.

Risks

Medium, there can always be hidden changes, but this branch is to serve as a testing bastion for these kinds of unexpected changes.

Rollback steps

  • revert this branch

@dmosorast dmosorast changed the title Move to API version 2019-07 and bump SDK version to latest Move to API version 2019-10 and bump SDK version to latest Mar 24, 2020
@dmosorast dmosorast merged commit bc81684 into master Mar 24, 2020
@dmosorast dmosorast deleted the api_version_upgrade branch March 24, 2020 17:44
@dmosorast dmosorast mentioned this pull request Mar 24, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants