Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status field to products stream #108

Merged
merged 1 commit into from
May 28, 2021

Conversation

kv-jokr
Copy link
Contributor

@kv-jokr kv-jokr commented May 25, 2021

Description of change

Adding status field to Products stream as specified in https://shopify.dev/docs/admin-api/rest/reference/products/product#index-2021-04

QA steps

  • automated tests passing
  • manual qa steps passing (list below)
    tap-shopify --discover -c ./config.json > catalog.json > status present in JSON File
    tap-shopify -c config.json --catalog catalog.json > status present in tap output

Risks

Rollback steps

  • revert this branch

@cosimon cosimon merged commit 727d063 into singer-io:master May 28, 2021
@cosimon cosimon mentioned this pull request May 28, 2021
2 tasks
tmck-code pushed a commit to lexerdev/tap-shopify that referenced this pull request Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants