Rate limits

[jmc-bbk]

Description of change

ReCharge rate limits have changed which causes a 429 ERROR. Connector is broken on Stitch.

Current rate limit is (160,60).

However, from Recharge Documentation:

https://developer.rechargepayments.com/#rate-limits

The API call limit operates using a “leaky bucket” algorithm as a controller. This allows for infrequent bursts of calls and allows your app to continue to make an unlimited amount of calls over time. The bucket size is 40 calls (which cannot be exceeded at any given time), with a “leak rate” of 2 calls per second that continually empties the bucket. If your app averages 2 calls per second, it will never trip a 429 error (“bucket overflow”).

Proposed change is to alter rate limits to (120,60) to never trip 429 error.

Manual QA steps

Couldn't manual QA cannot get dependencies working on Mac w/ M1 Chip. Think this PR is low risk. Would appreciate some help with QA if 100% necessary. Connector is broken in current form.

Risks

Low. Only proposed a reduction in the calls per minute.

Rollback steps

Revert to v1.0.3.

[cmerrick]

Hi @jmc-bbk, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

[jmc-bbk]

Hi @jmc-bbk, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

Done 👍

[cmerrick]

You did it @jmc-bbk!

Thank you for signing the Singer Contribution License Agreement.

[JDW818]

@jmc-bbk nice catch! I just ran into this exact same issue and popped into the repo to see if anyone had brought it up.

@cmerrick just curious if you have an ETA on this as we've got some data waiting to be processed. Thanks!

[JDW818]

@KAllan357 @cmerrick are there any updates on this? This is currently a blocker on a client project. Any info you can provide regarding an ETA is appreciated. Thanks!

[JakeBerube]

I can confirm that this is still broken. @KAllan357 @cmerrick Are there any updates on this?

[robindebois]

Also confirming this is still an issue. What is the progress on this PR? It's a 1 line change that is well documented by ReCharge and seems to have been open for months... Can I help in any way in getting this through?