Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Resolves #94
Another solution: #95
Python can only parse dates up to
9999-12-31
. When we try to work with a date past the maximum supported, a ValueError is being thrown.These dates are invalid anyway, so I decided to just hardcode them to the maximum supported date.
QA steps
I actually couldn't make the logical replication slot working. Other than that, all unit tests pass.
Manual test:
INSERT
query againResult value in Snowflake -
9999-12-31 00:00:00.000
Risks
We'd obviously have some data loss when we have dates 8000 years from now.
Rollback steps