Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add age and stay_in_pipeline_stages fields in deals schema #87

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Fortichoun
Copy link

@Fortichoun Fortichoun commented Mar 3, 2021

Description of change

This PR will add age and stay_in_pipeline_stages fields in the deal schema

Manual QA steps

Risks

Very low, this PR only add 2 fields for the deals schema

Rollback steps

Revert this branch

@cmerrick
Copy link
Contributor

cmerrick commented Mar 3, 2021

Hi @Fortichoun, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@cmerrick
Copy link
Contributor

cmerrick commented Mar 3, 2021

You did it @Fortichoun!

Thank you for signing the Singer Contribution License Agreement.

@Fortichoun
Copy link
Author

Hello,
I see that nothing has change since the opening of my PR 3 weeks ago.
Do I need to do something else to permit the validation of my PR ?

Thanks guys !

Copy link

@b-luu b-luu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Hello Singer team, can these quick and easy schema evolution PRs please be merged ASAP ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants