TDL-18712 Add support of EU endpoint. #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbshah1212
reviewed
Apr 22, 2022
README.md
Outdated
| @@ -246,6 +266,7 @@ Interrupted syncs for Event type stream are resumed via a bookmark placed during | |||
| - `period` (string, `ABCdef123`): `dayRange` or `hourRange` | |||
| - `lookback_window` (integer): 10 (For event objects. Default: 0) | |||
| - `request_timeout` (integer): 300 (For passing timeout to the request. Default: 300) | |||
| - `eu_domain` (boolean, `true` or `false`): EU domain refers to the physical storage location of an organization's data or information. Setting this config parameter to true ensures that it uses the EU endpoint to capture the records. | |||
There was a problem hiding this comment.
Suggested change
| - `eu_domain` (boolean, `true` or `false`): EU domain refers to the physical storage location of an organization's data or information. Setting this config parameter to true ensures that it uses the EU endpoint to capture the records. | |
| - `eu_domain` (boolean, `true` or `false`): EU domain refers to the physical storage location of an organization's data or information. Setting this config parameter to true ensures that it uses the EU endpoint to capture the records else it will use the US endpoint to capture the records. |
dbshah1212
reviewed
Apr 22, 2022
README.md
Outdated
| @@ -246,6 +266,7 @@ Interrupted syncs for Event type stream are resumed via a bookmark placed during | |||
| - `period` (string, `ABCdef123`): `dayRange` or `hourRange` | |||
| - `lookback_window` (integer): 10 (For event objects. Default: 0) | |||
| - `request_timeout` (integer): 300 (For passing timeout to the request. Default: 300) | |||
| - `eu_domain` (boolean, `true` or `false`): EU domain refers to the physical storage location of an organization's data or information. Setting this config parameter to true ensures that it uses the EU endpoint to capture the records else it will use the US endpoint to capture the records. It is an optional property. | |||
There was a problem hiding this comment.
Suggested change
| - `eu_domain` (boolean, `true` or `false`): EU domain refers to the physical storage location of an organization's data or information. Setting this config parameter to true ensures that it uses the EU endpoint to capture the records else it will use the US endpoint to capture the records. It is an optional property. | |
| - `eu_domain` (boolean, `true` or `false`): It is an optional property. EU domain refers to the physical storage location of an organization's data or information. Setting this config parameter to true ensures that it uses the EU endpoint to capture the records else it will use the US endpoint by default to capture the records. |
dbshah1212
approved these changes
Apr 22, 2022
savan-chovatiya
approved these changes
Apr 22, 2022
dbshah1212
approved these changes
Apr 25, 2022
dbshah1212
requested review from
KrisPersonal,
kspeer825,
RushiT0122 and
cosimon
cosimon
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
integration_tokenends with.euintegration_tokenends with.usManual QA steps
integration_tokenends with .us then the default value of the base URL is used.Risks
Rollback steps