Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TDL-15362: Find better PK for poll_events #77

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

hpatel41
Copy link
Contributor

Description of change

TDL-15362: Find better PK for poll_events

  • Updated the Primary Key for poll events: 'visitor_id', 'account_id', 'poll_id', 'browser_time'

Manual QA steps

Risks

Rollback steps

  • revert this branch

@hpatel41 hpatel41 marked this pull request as ready for review December 1, 2021 08:48
savan-chovatiya and others added 5 commits December 9, 2021 11:22
* TDL-15317: Updated primary key for feature-events

* Moved integration test

* TDL-15317: Updated integration test

* updated readme file

* Resolved internal PR review comments

* Resolved review comments

* run bookmark test with hour and day range

Co-authored-by: harshpatel4_crest <[email protected]>
Co-authored-by: Harsh <[email protected]>
* updated PK for track_events stream

* updated the comment according to the comments

* updated readme file

* added unittest

* updated unittests, updated config.yml file

* run bookmark test for day and hour range

* Disabling integration test for merge and enable it in pendo-pk-changes

Co-authored-by: harshpatel4_crest <[email protected]>
Co-authored-by: Harsh <[email protected]>
* TDL-15338: Updated primary keys for events

* TDL-15338: Updated integration test

* updated readme file

* Resolved internal PR review comments

* Resolved review comments

* run bookmark test with hour and day range

Co-authored-by: harshpatel4_crest <[email protected]>
Co-authored-by: Harsh <[email protected]>
* updated PK for guide events

* added unittests

* updated readme file

Co-authored-by: harshpatel4_crest <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants