-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TDL-15362: Find better PK for poll_events #77
Open
hpatel41
wants to merge
8
commits into
master
Choose a base branch
from
TDL-15362-poll-events-PK
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savan-chovatiya
approved these changes
Dec 2, 2021
karanpanchal-crest
approved these changes
Dec 8, 2021
KrisPersonal
approved these changes
Dec 8, 2021
* TDL-15317: Updated primary key for feature-events * Moved integration test * TDL-15317: Updated integration test * updated readme file * Resolved internal PR review comments * Resolved review comments * run bookmark test with hour and day range Co-authored-by: harshpatel4_crest <[email protected]> Co-authored-by: Harsh <[email protected]>
* updated PK for track_events stream * updated the comment according to the comments * updated readme file * added unittest * updated unittests, updated config.yml file * run bookmark test for day and hour range * Disabling integration test for merge and enable it in pendo-pk-changes Co-authored-by: harshpatel4_crest <[email protected]> Co-authored-by: Harsh <[email protected]>
* TDL-15338: Updated primary keys for events * TDL-15338: Updated integration test * updated readme file * Resolved internal PR review comments * Resolved review comments * run bookmark test with hour and day range Co-authored-by: harshpatel4_crest <[email protected]> Co-authored-by: Harsh <[email protected]>
* updated PK for guide events * added unittests * updated readme file Co-authored-by: harshpatel4_crest <[email protected]>
…endo into TDL-15362-poll-events-PK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
TDL-15362: Find better PK for poll_events
'visitor_id', 'account_id', 'poll_id', 'browser_time'
Manual QA steps
Risks
Rollback steps