Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The source param for the trackEvents source is trackTypeId #30

Merged
merged 1 commit into from
Apr 15, 2021
Merged

The source param for the trackEvents source is trackTypeId #30

merged 1 commit into from
Apr 15, 2021

Conversation

cosimon
Copy link
Contributor

@cosimon cosimon commented Apr 15, 2021

Description of change

According to the pendo docs, the source param for the source type of trackEvents is trackTypeId, not trackId
https://developers.pendo.io/docs/?bash#source-specification

Manual QA steps

  • Ran without this change, we were receiving a 400 with the error text bad pipeline: bad source: bad parameters for source type trackEvents: unexpected parameters.
  • Ran with this change and we successfully synced trackEvents.

Risks

  • The tap was catching 400 exceptions and only logging a warning. The tap should have failed upon receiving a 400 from Pendo.

Rollback steps

  • revert this branch

@cosimon cosimon merged commit d715866 into master Apr 15, 2021
@cosimon cosimon deleted the fix/update-track-events-query-param branch April 15, 2021 17:37
@erinkcochran87 erinkcochran87 mentioned this pull request May 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leslievandemark leslievandemark leslievandemark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cosimon @leslievandemark