Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Default Include Anonymous Visitors, handle None values, add unit tests #111

Merged
merged 3 commits into from
Sep 8, 2022
Merged

Set Default Include Anonymous Visitors, handle None values, add unit tests #111

merged 3 commits into from
Sep 8, 2022

Conversation

dsprayberry
Copy link
Contributor

Description of change

Addresses an issue stemming from empty include_anonymous_visitors properties.

Manual QA steps

  • Unit Tests passing

Risks

  • Minimal.

Rollback steps

  • revert this branch

@dsprayberry dsprayberry requested a review from luandy64 September 1, 2022 20:22
luandy64
luandy64 requested changes Sep 1, 2022
View reviewed changes
tap_pendo/streams.py Outdated Show resolved Hide resolved
@dsprayberry dsprayberry requested a review from luandy64 September 1, 2022 20:58
@dsprayberry dsprayberry mentioned this pull request Sep 7, 2022
Merged
@dsprayberry dsprayberry requested a review from luandy64 September 7, 2022 17:33
@dsprayberry dsprayberry merged commit 0a61171 into master Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luandy64 luandy64 luandy64 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsprayberry @luandy64