Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove maxLength from the catalog #88

Merged
merged 2 commits into from
Jun 22, 2023
Merged

Remove maxLength from the catalog #88

merged 2 commits into from
Jun 22, 2023

Conversation

luandy64
Copy link
Contributor

@luandy64 luandy64 commented Jun 2, 2023

Description of change

This PR removes maxLength from the JSON schema.

QA steps

  • automated tests passing
  • manual qa steps passing (list below)

Risks

  • Low. Schema validation can fail when we include these values, but it's seems to be stricter than MSSQL is. There's no value in the tap complaining some value looks wrong when the database says the same thing

Rollback steps

  • revert this branch

@luandy64 luandy64 merged commit 7413ec6 into master Jun 22, 2023
@luandy64 luandy64 deleted the tdl-23162/remove-schema-length-restrictions branch June 22, 2023 14:06
@luandy64 luandy64 mentioned this pull request Jun 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsprayberry dsprayberry dsprayberry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luandy64 @dsprayberry