Fix/discovery database permissions error #33
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
https://stitchdata.atlassian.net/browse/SUP-1512
The behavior of tap-mssql, it seems, differs from the other database taps, in that, there are cases of permissions where a user doesn't have access to all databases, in which case the tap fails.
This PR handles a very specific permissions error that can occur during discovery to align this behavior with other database taps.
The solution to fall back to a try/catch pattern came from the apparent lack of ability to query a user's permissions on a database without first connecting to the database (at which point an exception would be raised if they have no access).
QA steps
Risks
Low, it's just error handling.
Rollback steps