Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/discovery database permissions error #33

Merged
merged 2 commits into from
May 15, 2020

Conversation

dmosorast
Copy link
Contributor

@dmosorast dmosorast commented May 15, 2020

Description of change

https://stitchdata.atlassian.net/browse/SUP-1512

The behavior of tap-mssql, it seems, differs from the other database taps, in that, there are cases of permissions where a user doesn't have access to all databases, in which case the tap fails.

This PR handles a very specific permissions error that can occur during discovery to align this behavior with other database taps.

The solution to fall back to a try/catch pattern came from the apparent lack of ability to query a user's permissions on a database without first connecting to the database (at which point an exception would be raised if they have no access).

QA steps

  • manual qa steps passing (list below)
    • Ran through a bunch of queries on local test DB and wrote local integration test for this case

Risks

Low, it's just error handling.

Rollback steps

  • revert this branch, bump patch, release

@asaf-erlich
Copy link

Looks good to me but please ask someone who more clojure and / or general tap review experience.

src/tap_mssql/catalog.clj Show resolved Hide resolved
@dmosorast dmosorast merged commit f1362ea into master May 15, 2020
@dmosorast dmosorast deleted the fix/discovery-database-permissions-error branch May 15, 2020 20:28
@dmosorast dmosorast mentioned this pull request May 15, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants