-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw an error if min_valid_version is null #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment re: table name matching for getting object_id. There is an Object_id function as well, but Kyle says that may not have been working? https://docs.microsoft.com/en-us/sql/t-sql/functions/object-id-transact-sql?view=sql-server-ver15
Also, are there tests for this already? Maybe adding one that creates 2 different schemas could be useful.
Description of change
In logical replication, sometimes our query here returns
nil
tap-mssql/src/tap_mssql/sync_strategies/logical.clj
Lines 95 to 99 in 1bfc58d
And when that happens, the tap will eventually try
(> nil 12345)
which causes ajava.lang.NullPointerException
.QA steps
Risks
Rollback steps