Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sanitize schema names #20

Merged
merged 6 commits into from
Feb 11, 2020
Merged

Conversation

cosimon
Copy link
Contributor

@cosimon cosimon commented Feb 10, 2020

Description of change

https://stitchdata.atlassian.net/browse/SRCE-2286

Surround the schema name with square brackets like we do table names and column names. This will allow otherwise reserved words/characters to be in the schema

QA steps

  • automated tests passing
  • manual qa steps passing (list below)

Risks

Medium - Changing the way we format schema names affects all database interactions. An error here will break everything.

Rollback steps

  • revert this branch

@KAllan357
Copy link
Contributor

Sanitizing this data appears isolated to the query building functions but do we have tests here or in tap-tester that ensure the sanitized names aren't leaking anywhere? IE in the messages output to stdout.

@cosimon
Copy link
Contributor Author

cosimon commented Feb 11, 2020

Sanitizing this data appears isolated to the query building functions but do we have tests here or in tap-tester that ensure the sanitized names aren't leaking anywhere? IE in the messages output to stdout.

Yes, in tap-tester's discovery_test_data_types.py there are tests that check the schema name is correct.

@cosimon cosimon merged commit 0c864d3 into master Feb 11, 2020
@cosimon cosimon deleted the feature/sanitize-schema-names branch February 11, 2020 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants