Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transform binary types to hex strings #16

Merged
merged 2 commits into from
Dec 17, 2019
Merged

transform binary types to hex strings #16

merged 2 commits into from
Dec 17, 2019

Conversation

nick-mccoy
Copy link
Contributor

Description of change

During discovery, for columns of type binary the tap writes the schema as a string, but does not transform the data to a string, instead emitting it as a byte array.

This PR changes the tap to transform columns of type binary to a hex string.

QA steps

  • tested on cloned connection that was failing schema validation and is now passing

Risks

Rollback steps

  • revert this branch

dmosorast
dmosorast requested changes Dec 16, 2019
View reviewed changes
Copy link
Contributor

@dmosorast dmosorast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, approval pending added test case for this type.

@nick-mccoy nick-mccoy merged commit 0854b1d into master Dec 17, 2019
@nick-mccoy nick-mccoy deleted the transform-binary-types branch December 17, 2019 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmosorast dmosorast dmosorast approved these changes

@KAllan357 KAllan357 KAllan357 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nick-mccoy @KAllan357 @dmosorast