Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/timestamps cause query exceptions #15

Merged
merged 6 commits into from
Dec 11, 2019

Conversation

KAllan357
Copy link
Contributor

@KAllan357 KAllan357 commented Dec 9, 2019

Description of change

https://stitchdata.atlassian.net/browse/SRCE-1959

QA steps

  • automated tests passing
  • manual qa steps passing (list below)

Risks

Rollback steps

  • revert this branch

Kyle Allan and others added 6 commits December 5, 2019 14:27
an interrtupted Full Table sync using a timestamp column
causes a SQLServerException because the value is transformed.

Motivation
----------

API changes
-----------

Implementation Notes
--------------------

Functional Tests
----------------

Regression Tests
----------------

Screenshots
-----------
Copy link
Contributor

@dmosorast dmosorast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Some nice cleanup in there

@KAllan357 KAllan357 merged commit bebc27b into master Dec 11, 2019
@KAllan357 KAllan357 deleted the bug/timestamps-cause-query-exceptions branch December 11, 2019 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants