Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update __init__.py #82

Merged
merged 2 commits into from
Jan 29, 2019
Merged

Update __init__.py #82

merged 2 commits into from
Jan 29, 2019

Conversation

EternalLearner42
Copy link
Contributor

Fixes #81

@cmerrick
Copy link
Contributor

Hi @EternalLearner42, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@luandy64
Copy link
Contributor

This PR is almost complete. Aside from the CLA needing to be signed, the for loop needs to drop the _ too. Let me know if you need help @EternalLearner42 👍

@EternalLearner42
Copy link
Contributor Author

@cmerrick Very well, I'll sign, but I hope you'll safeguard my personal information.

@luandy64 Yeah, I completely missed that part. The "_" part, from what I see, does not affect any of the remaining code. All I have to do is take it out, right?

@cmerrick
Copy link
Contributor

You did it @EternalLearner42!

Thank you for signing the Singer Contribution License Agreement.

@EternalLearner42
Copy link
Contributor Author

Forgive my trolly signature and company :P

@EternalLearner42
Copy link
Contributor Author

There, done. Feel free to tell me any other thing I can do

@luandy64
Copy link
Contributor

This looks good to me! 👍

Remember that the Python convention is that _ means we don't care about whatever value is assigned to _. Even though you technically can still access the value associated the _.

Here's a REPL example:

>>> a = {'a':1, 'b':2}
>>> for _, val in a.items():
...   print(_, val)
...
a 1
b 2

@luandy64 luandy64 merged commit d603d25 into singer-io:master Jan 29, 2019
@EternalLearner42
Copy link
Contributor Author

Thanks! I did not know of this convention, thus my getting a bit mixed up, but thanks a lot for the help! Hope I'll be able to help with a more advanced issue in the future 👍

mdimercurio added a commit to dialoguemd-archives/tap-hubspot that referenced this pull request Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants