Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change auth to GitHub apps #163

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

raulsh
Copy link

@raulsh raulsh commented Mar 15, 2022

Description of change

Personal access token have a lower rate limit. This PR replaces actual auth to GitHub Apps authentication


headers = {
"Authorization": "Bearer {}".format(jwt_token),
"Accept": "application/vnd.github.machine-man-preview+json"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this is still needed? I think the API change graduated. See google/go-github#1616

@ericboucher
Copy link

ericboucher commented Apr 21, 2022

Hey @raulsh I think this a good idea, but:

  • it should not be exclusive and users should be able to use a personal token
  • we need to add documentation / links on how to get the values. Showing example values for app_id, installation_id and private_key would be nice so that users know what they should be inputting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants