Add fallback username for Docker run environment #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raido
changed the title
|
I forgot about this... Would you be able to fix the merge conflict? |
raido
force-pushed
the
fix-docker-username
branch
2 times, most recently
from
7418088
to
2fe841a
Compare
raido
force-pushed
the
fix-docker-username
branch
from
2fe841a
to
596b563
Compare
|
@sindresorhus Rebased on master. |
sindresorhus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idea is to first get the userId and then try to get username for that specific id. If that fails we fallback to our own generated username.
Closes: #21