-
-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split internal.d.ts
into multiple files
#906
Split internal.d.ts
into multiple files
#906
Conversation
I don't mind this, but I also don't see a strong need to do it. Ideally, many of these types should be exported publicly instead (#676). One thing I don't want is to nest the tests into folder. I think all the internal types should be top-level tests in the |
internal.d.ts
into multiple filesinternal.d.ts
into multiple files, expose some types
Updated tests and exposes some internal types that I found requests for in the issues. Please see the lines marked |
When I mentioned exporting types, I didn't really mean in this pull request. It would be better to have separate pull requests for each exposed type, to make it easier to review and also to track changes for release notes. |
5396914
to
47496e3
Compare
Unexposed types and added to separate PRs. |
/** | ||
Matches any unknown array or tuple. | ||
*/ | ||
export type UnknownArrayOrTuple = readonly [...unknown[]]; | ||
// TODO: should unknown-array be updated? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need both of these types?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know. I don't think that's relevant to this pull request though. Open a separate issue about it.
internal.d.ts
into multiple files, expose some typesinternal.d.ts
into multiple files
Splits the types in
internal.d.ts
into multiple category-based files to improve maintainability, with the following structure:Other miscellaneous changes:
ArrayMax
/ArrayMin
toTupleMax
/TupleMin
. This can be reverted if desired.I tried maintaining the order of types and their formatting when copying them over, but I could've missed something.