Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NonEmptyObject type #623

Merged
merged 11 commits into from
Aug 25, 2023
Merged

Conversation

kkmuffme
Copy link
Contributor

Close #621

@kkmuffme
Copy link
Contributor Author

kkmuffme commented May 21, 2023

@sindresorhus the failing test reports an error in an empty line? Could you please pinpoint me at what the issue is?

Looked at the .ts instead of the .d.ts by accident.

@kkmuffme kkmuffme marked this pull request as ready for review May 23, 2023 14:26
@sindresorhus
Copy link
Owner

The diff view shows the error inline. You should also always run npm test locally before pushing, which also shows the error description.

@sindresorhus sindresorhus mentioned this pull request Aug 8, 2023
@kkmuffme kkmuffme force-pushed the type-non-empty-object branch from b4aa394 to 8e818b8 Compare August 8, 2023 09:48
@sindresorhus
Copy link
Owner

Closing for lack of response.

@kkmuffme
Copy link
Contributor Author

kkmuffme commented Aug 8, 2023

It's done this second :D

@kkmuffme
Copy link
Contributor Author

kkmuffme commented Aug 8, 2023

@sindresorhus ha ha, I just fixed and finished it in exactly the second you closed it. Can you reopen & merge it please.

@sindresorhus sindresorhus reopened this Aug 18, 2023
source/non-empty-object.d.ts Outdated Show resolved Hide resolved
source/non-empty-object.d.ts Outdated Show resolved Hide resolved
source/non-empty-object.d.ts Outdated Show resolved Hide resolved
source/non-empty-object.d.ts Show resolved Hide resolved
test-d/non-empty-object.ts Outdated Show resolved Hide resolved
test-d/non-empty-object.ts Outdated Show resolved Hide resolved
@sindresorhus
Copy link
Owner

You need to fix the merge conflicts.

@kkmuffme kkmuffme force-pushed the type-non-empty-object branch from 8e818b8 to 5c357fc Compare August 18, 2023 17:30
@kkmuffme kkmuffme force-pushed the type-non-empty-object branch from 95a5a2e to d0f7964 Compare August 18, 2023 17:34
@sindresorhus
Copy link
Owner

Tests are failing.

@kkmuffme kkmuffme requested a review from sindresorhus August 23, 2023 12:44
@kkmuffme
Copy link
Contributor Author

@sindresorhus all tests pass, please review again and merge it

@sindresorhus sindresorhus merged commit 98bb74d into sindresorhus:main Aug 25, 2023
@sindresorhus
Copy link
Owner

Thanks ;)

@kkmuffme kkmuffme deleted the type-non-empty-object branch August 29, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NonEmptyObject
2 participants