Fix DelimiterCase regression after TS 4.8 (#464)

sindresorhus · Sep 15, 2022 · 2a2f310 · 2a2f310
1 parent 6df18e3
commit 2a2f310
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/source/delimiter-case.d.ts b/source/delimiter-case.d.ts
@@ -88,7 +88,7 @@ const rawCliOptions: OddlyCasedProperties<SomeOptions> = {
 @category Change case
 @category Template literal
 */
-export type DelimiterCase<Value, Delimiter extends string> = Value extends string
+export type DelimiterCase<Value, Delimiter extends string> = string extends Value ? Value : Value extends string
 	? StringArrayToDelimiterCase<
 	SplitIncludingDelimiters<Value, WordSeparators | UpperCaseCharacters>,
 	true,

diff --git a/test-d/delimiter-case.ts b/test-d/delimiter-case.ts
@@ -48,9 +48,8 @@ expectType<'##very#prefixed'>(delimiterFromDoublePrefixedKebab);
 const delimiterFromRepeatedSeparators: DelimiterCase<'foo____bar', '#'> = 'foo####bar';
 expectType<'foo####bar'>(delimiterFromRepeatedSeparators);
 
-// TODO: Fails after TS 4.8.
-// const delimiterFromString: DelimiterCase<string, '#'> = 'foobar';
-// expectType<string>(delimiterFromString);
+const delimiterFromString: DelimiterCase<string, '#'> = 'foobar';
+expectType<string>(delimiterFromString);
 
 const delimiterFromScreamingSnake: DelimiterCase<'FOO_BAR', '#'> = 'foo#bar';
 expectType<'foo#bar'>(delimiterFromScreamingSnake);