Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recognize bigint as stringifiable #377

Merged
merged 3 commits into from
Feb 3, 2024
Merged

Conversation

bug-brain
Copy link
Contributor

This would be a nice feature to prevent some explicit .toString()´ calls before passing an object to stringify`.

@sindresorhus
Copy link
Owner

I'm willing to merge this, but you need to fix the lint issues.

@bug-brain
Copy link
Contributor Author

bug-brain commented Jan 31, 2024

Going for [email protected] would require (edit: shows up as red) using String#replaceAll() instead of String#replace(). For the two usages this would not be breaking but I prefer changing less for this feature because it is technically only a typing issue.

@sindresorhus sindresorhus merged commit 7f84490 into sindresorhus:main Feb 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants