Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite in TypeScript #336

Closed
sindresorhus opened this issue Sep 7, 2018 · 2 comments
Closed

Rewrite in TypeScript #336

sindresorhus opened this issue Sep 7, 2018 · 2 comments
Labels
enhancement help wanted

Comments

@sindresorhus
Copy link
Owner

I originally rewrote it in Flow to get a feel for it. These days I only use TypeScript, so I would prefer to make this be in TypeScript too.

PR welcome if you want the challenge.
@joshghent
Copy link

I'll have a crack at this 👍

@sindresorhus
Copy link
Owner Author

@joshghent Awesome! Let me know if you have any questions. You can use the same tsconfig and linting setup as used in https://github.com/sindresorhus/is.

@cluk3 cluk3 mentioned this issue Oct 28, 2018
Merged
sindresorhus added a commit that referenced this issue Feb 7, 2019
@cluk3 @sindresorhus
Rewrite in TypeScript (#339)
25018da 
Fixes #336


Co-authored-by: Sindre Sorhus <[email protected]>
sindresorhus added a commit that referenced this issue Feb 7, 2019
@cluk3 @sindresorhus
Start TypeScript rewrite (#339)
42ff5ae 
Fixes #336

Co-authored-by: Sindre Sorhus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sindresorhus @joshghent