Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error & completed events #130

Merged
merged 8 commits into from
Mar 31, 2021

Conversation

dobesv
Copy link
Contributor

@dobesv dobesv commented Mar 26, 2021

These events can be useful for use cases like tracking metrics & logging errors centrally.

test/test.ts Outdated Show resolved Hide resolved
@sindresorhus sindresorhus changed the title Emit error & completed events Add error & completed events Mar 28, 2021
@dobesv
Copy link
Contributor Author

dobesv commented Mar 31, 2021

OK I think I fixed this, let me know if there's more to do

@sindresorhus sindresorhus merged commit a176837 into sindresorhus:main Mar 31, 2021
Totenfluch pushed a commit to Totenfluch/p-queue that referenced this pull request Jul 18, 2021
Arnagos pushed a commit to Arnagos/p-queue that referenced this pull request May 2, 2022
Co-authored-by: Sindre Sorhus <[email protected]>
# Conflicts:
#	readme.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants