Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added import to package.json #247

Closed
wants to merge 2 commits into from
Closed

Conversation

omerlh
Copy link

@omerlh omerlh commented Dec 15, 2022

Potential fix for #246 , I am not clear about the implications of this change but I tested locally and it worked for me - now I could use ow and React.

Fixes #246

@sindresorhus
Copy link
Owner

I think import is correct here, but you can drop the node one then.

@omerlh omerlh marked this pull request as ready for review December 18, 2022 05:15
@omerlh
Copy link
Author

omerlh commented Dec 18, 2022

Fixed

},
"./dev-only": {
"types": "./dist/index.d.ts",
"node": "./dev-only.js"
"import": "./dist/index.js"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect file

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which file should be imported than?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this should be "import": "./dev-only.js" on line 21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build errors when using ow in React app compiled with vite
3 participants