Add ow.bigint
#212
Merged
Add ow.bigint
#212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 5, 2021 10:20
wafuwafu13
commented
Jun 5, 2021
| @@ -2,9 +2,9 @@ | |||
| "extends": "@sindresorhus/tsconfig", | |||
| "compilerOptions": { | |||
| "outDir": "dist", | |||
| "target": "es2018", | |||
| "target": "es2020", | |||
There was a problem hiding this comment.
Change because test failed.
Uncaught exception in test/bigint.ts
test/bigint.ts:12:6 - error TS2737: BigInt literals are not available when targeting lower than ES2020.
12 ow(9007199254740991n, ow.bigint);
~~~~~~~~~~~~~~~~~
wafuwafu13
commented
Jun 5, 2021
test/types.ts
Outdated
| @@ -106,6 +106,8 @@ function typeTests(value: unknown): Array<(() => void)> { | |||
| const tests: Tests = { | |||
| array: expect => expect.toBeArray(), | |||
| arrayBuffer: expect => expect.toEqualTypeOf<ArrayBuffer>(), | |||
| // eslint-disable-next-line node/no-unsupported-features/es-builtins, node/no-unsupported-features/es-syntax | |||
| bigint: expect => expect.toEqualTypeOf<BigInt>(10n as never), | |||
There was a problem hiding this comment.
I'm not sure what the screenshot is trying to illustrate? But it's better to use @ts-expect-error if there's really no way to make it work.
There was a problem hiding this comment.
OK. I use @ts-expect-error. 83657b6
|
I don't know why only node10,12 fails the test because of SyntaxError. |
It's fine. I'm going to drop Node.js 10 support after merging this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve: #54