Add asserts annotations
#194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds: - Type-level tests with expect-type - A generic typearg for ArrayPredicate and ObjectPredicate - A Shape -> TypeOfShape helper Changes: - The `optional` modifier now makes each predicate ThePredicate<T | undefined> rather than Predicate<T> (which could lead to uncaught NREs) - The hidden create-constructor is no longer allowed to pass in undefined for any value, since undefineds should now be properly tracked.
mmkal
changed the title
asserts annotations to main functionasserts annotations
|
Thanks for working on this 🙌 |
|
This looks great! Thank you :) |
vladfrangu
pushed a commit
to vladfrangu/ow
that referenced
this pull request
Jan 7, 2021
vladfrangu
pushed a commit
to vladfrangu/ow
that referenced
this pull request
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #159
Also adds:
ow.array.ofType(ow.string)infersstring[]andow.object.exactShape({ foo: ow.string, bar: ow.object.exactShape({ baz: ow.number }) })infers{ foo: string; bar: { baz: number } }Changes:
optionalmodifier now makes each predicate ThePredicate<T | undefined> rather than Predicate (which could lead to uncaught NREs)