Added string-width to dependencies #228
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
[email protected]
uses thestring-width
package, but doesn't include it as a dependency or peer-dependency.Implication
Users that install & import the latest version of
ora
for the first time will run into the following runtime error ifstring-width
isn't specifically listed as a dependency or required by any other dependencies.This error is caused by Line 7 in
node_modules/ora/index.js
Solution
Add
string-width
as a dependency or peer-dependency in ora'spackage.json
.Problem & Solution Tested On
Last Working Version
[email protected]
) works as expected as it doesn't depend on or import thestring-width
package.