Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newInstance option for macOS #253

Merged
merged 6 commits into from
May 24, 2021

Conversation

Kudo
Copy link
Contributor

@Kudo Kudo commented May 21, 2021

The open command in macOS will try to reuse existing instance by default.
Adding open -n will create a new instance no matter if there is existing instance or not.
For Windows and Linux, the behavior are to create new instances anyway.
The PR proposes to add a macOS only newInstance option and by default it's false.

Not sure if the change making sense or not. feel free to comment for better solution.

@Kudo
Copy link
Contributor Author

Kudo commented May 24, 2021

thanks @sindresorhus for landing edge support. any chance for you to review this?
please feel free to let me know if you have any concern for this.

index.js Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated

Open a new instance of the application(s) even if one is already running.

On other platforms, this is always to open a new instance.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be better written.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to For other platforms, this value is always to be true.
is this better?

@sindresorhus sindresorhus changed the title Add newInstance for macOS Add newInstance option for macOS May 24, 2021
@Kudo
Copy link
Contributor Author

Kudo commented May 24, 2021

updated changes based on your comment, please help to review again.
thank you so much @sindresorhus

@Kudo Kudo requested a review from sindresorhus May 24, 2021 13:40
@sindresorhus sindresorhus merged commit 5e663d6 into sindresorhus:main May 24, 2021
@Kudo
Copy link
Contributor Author

Kudo commented May 24, 2021

@sindresorhus Thank you for the great revise and quick review 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants