Update dependencies #734
Merged
Update dependencies #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommy-mitchell
commented
Feb 29, 2024
| test.skip('external registry', createFixture, [{ | ||
| command: `${accessCommand()} --registry http://my-internal-registry.local`, | ||
| stdout: collaboratorsStdout, | ||
| }], async ({t, testedModule: {collaborators}}) => { |
There was a problem hiding this comment.
This test is behaving weirdly. It's passing, but afterwards it hangs and causes the test file to timeout.
There was a problem hiding this comment.
AVA 6 changed to no longer force exit the process at the end, which may be related.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updates CI version matrix and removes some extraneous TODO comments from #689.
There was some leftover logic for the npm collaborators test that was used for verifying it worked between npm v8 and v9 - it's been removed since we don't support v8 anymore.
Closes #714.