Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal improvements, add more tests #689

Merged
merged 66 commits into from
Sep 2, 2023
Merged
Changes from 1 commit
Commits
Show all changes
66 commits
Select commit Hold shift + click to select a range
d3df4f8
chore: start separating tests
tommy-mitchell Apr 6, 2023
636eb0b
tests(`git`): add tests for `git-util.js`
tommy-mitchell Apr 7, 2023
e822ae9
further separate tests, add `npm` tests, style
tommy-mitchell Apr 8, 2023
22cac30
fix(`git`): move tests to integration, fix `defaultBranch` tests
tommy-mitchell Apr 8, 2023
796595d
tests(`util`): add more tests
tommy-mitchell Apr 8, 2023
af48c4e
feat(`pretty-version-diff`): simplify and add tests
tommy-mitchell Apr 9, 2023
dce03f5
update `Version` API, remove `pretty-version-diff.js`, consolidate ta…
tommy-mitchell Apr 11, 2023
49378f4
fix(`test/index`): incorrect message expectation
tommy-mitchell Apr 11, 2023
993a53e
fix(`version`): passing test marked as failing
tommy-mitchell Apr 11, 2023
f6b988e
chore(`version`): rename `setNewVersionFrom` to `setFrom`
tommy-mitchell Apr 11, 2023
76dd173
chore: bump `semver`
tommy-mitchell Apr 11, 2023
75a2156
fix(`version`): get correct diff
tommy-mitchell Apr 11, 2023
722370b
chore(`version`): use new `semver.RELEASE_TYPES`
tommy-mitchell Apr 11, 2023
9097485
fix(`packed-files`): don't rename `.gitignore`
tommy-mitchell Apr 11, 2023
68997f1
feat(`version`): improved prerelease diffs, more docs
tommy-mitchell Apr 12, 2023
280c66e
feat(`version`): update/document API
tommy-mitchell Apr 13, 2023
21eeab1
tests(`prerequisite-tasks`): test is passing now?
tommy-mitchell Apr 13, 2023
d234532
tests: add more `git` and `npm` tests
tommy-mitchell Apr 14, 2023
d258504
fix: comment out unused imports
tommy-mitchell Apr 14, 2023
7a39e51
docs: update old info on readme
tommy-mitchell Apr 14, 2023
12a3650
add `ui`/`cli` tests, improve `customVersion` validation, style impro…
tommy-mitchell Apr 18, 2023
ef1d2e9
update CI to Node.js 20
tommy-mitchell Apr 18, 2023
b854b81
tests(`cli`): try to fix failure on CI
tommy-mitchell Apr 19, 2023
d675d1f
Merge branch 'main' into improve-tests
tommy-mitchell Apr 19, 2023
9d810a1
feat: add changes from #932, add tests
tommy-mitchell Apr 19, 2023
f2bc525
undo Node.js 20 on CI, issues with `esmock`
tommy-mitchell Apr 19, 2023
2b502c3
Merge branch 'main' into improve-tests
tommy-mitchell Jul 2, 2023
e403bf9
update deps
tommy-mitchell Jul 2, 2023
26accf9
fix(`npm`): incorrect version handling, missing async, style fix
tommy-mitchell Jul 4, 2023
366c8c3
suppress ESM warnings on tests
tommy-mitchell Jul 4, 2023
f5331c4
tests(`npm`): finish adding tests, seperate into own files
tommy-mitchell Jul 4, 2023
bab7bb2
mark tests as failing
tommy-mitchell Jul 4, 2023
438db1e
fix(`npm.collaborators`): revert version change
tommy-mitchell Jul 4, 2023
1ed67ac
remove reminders (added to #684)
tommy-mitchell Jul 4, 2023
da36e87
refactor(`cli`): move defaults into `meow` configuration
tommy-mitchell Jul 4, 2023
7534032
remove todos, update `chalk` usage, grammar tweak
tommy-mitchell Jul 4, 2023
649f7ef
update `esmock` to fix `ui` tests
tommy-mitchell Jul 30, 2023
f3c09b2
fix lint
tommy-mitchell Jul 30, 2023
0d262ea
fix lint
tommy-mitchell Jul 30, 2023
0413d1f
move `util` tests to separate files, fix failing tests, add test for…
tommy-mitchell Jul 31, 2023
676bdfd
move `git-util` tests to separate files
tommy-mitchell Jul 31, 2023
2eefd96
use `git add .` in tests
tommy-mitchell Jul 31, 2023
80cfc9d
fix: await create file
tommy-mitchell Jul 31, 2023
86c3ffd
tests(`hyperlink`): use `esmock`
tommy-mitchell Jul 31, 2023
213d374
fix(`hyperlinks`): mark tests as serial
tommy-mitchell Jul 31, 2023
f869534
tests(`hyperlinks`): properly mock `terminal-link`
tommy-mitchell Jul 31, 2023
a1618c1
rename `test/git` to `test/git-util`
tommy-mitchell Jul 31, 2023
784b2cd
tests(`git-util`): finish testing
tommy-mitchell Jul 31, 2023
53657bf
tests(`inquirer`): log debug messages with AVA
tommy-mitchell Jul 31, 2023
44a045a
handle todos, style tweaks
tommy-mitchell Jul 31, 2023
1cdf40b
fix lint
tommy-mitchell Jul 31, 2023
57c9df4
fix: correct config name
tommy-mitchell Jul 31, 2023
8d5ede5
document test helpers
tommy-mitchell Jul 31, 2023
bdc92fb
Merge branch 'improve-tests' of https://github.com/tommy-mitchell/np …
tommy-mitchell Jul 31, 2023
b286a28
remove todos
tommy-mitchell Jul 31, 2023
4aa52f8
fix: move `chalk-template` to regular deps
tommy-mitchell Jul 31, 2023
f140762
try resolving `util.readPkg` error
tommy-mitchell Aug 2, 2023
b06fc98
better resolution of issue
tommy-mitchell Aug 2, 2023
6ba3b4b
fixes
tommy-mitchell Aug 31, 2023
cd16b94
update deps
tommy-mitchell Aug 31, 2023
c92873c
fix: lint
tommy-mitchell Aug 31, 2023
361b609
fix: missing option in test
tommy-mitchell Aug 31, 2023
e3c5e5c
fix: ignore some checks when `--release-draft-only`
tommy-mitchell Aug 31, 2023
f98b85d
fix(`prerequisite-tasks`): don't double parse version
tommy-mitchell Sep 1, 2023
c6249a2
version style tweaks
tommy-mitchell Sep 1, 2023
a682b51
semver order
tommy-mitchell Sep 1, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(version): passing test marked as failing
tommy-mitchell committed Apr 11, 2023
commit 993a53e63079f34850b84454b6ac7bc70da6b3da
2 changes: 1 addition & 1 deletion test/version.js
Original file line number Diff line number Diff line change
@@ -118,7 +118,7 @@ test('format - prerelease', t => {
t.is(new Version('0.0.0-0').setNewVersionFrom('0.0.0-1').format(), newVersion);
});

test.failing('format - prerelease as prepatch', t => {
test('format - prerelease as prepatch', t => {
const newVersion = makeNewFormattedVersion('0.0.{1}-{0}');

t.is(new Version('0.0.0').setNewVersionFrom('prerelease').format(), newVersion);