Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only consider enabling autoHelp/autoVersion in case there is only one argument in process.argv #114

Merged
merged 9 commits into from
Jun 12, 2019
Merged

Only consider enabling autoHelp/autoVersion in case there is only one argument in process.argv #114

merged 9 commits into from
Jun 12, 2019

Conversation

LitoMore
Copy link
Contributor

Resolved #113

@sindresorhus
Copy link
Owner

The behavior needs to be documented.

sindresorhus
sindresorhus reviewed Feb 23, 2019
View reviewed changes
test.js Outdated Show resolved Hide resolved
sindresorhus
sindresorhus reviewed Feb 23, 2019
View reviewed changes
test.js Outdated Show resolved Hide resolved
@LitoMore
Copy link
Contributor Author

@sindresorhus Code updated. I documented this behavior in the Features section, is that OK?

sindresorhus
sindresorhus reviewed Feb 24, 2019
View reviewed changes
readme.md Outdated Show resolved Hide resolved
@LitoMore
Copy link
Contributor Author

For the document, I renamed the Tips section to Related, and add a new section named Tips for autoVersion and autoHelp tips.

@LitoMore
Copy link
Contributor Author

LitoMore commented Mar 7, 2019

@sindresorhus ping

@LitoMore
Copy link
Contributor Author

Any progress? @sindresorhus

@sindresorhus
Copy link
Owner

add a new section named Tips for autoVersion and autoHelp tips.

This should be document under the docs for those options, not in a Tips section. It's not a tip, it's documenting how something works.

sindresorhus
sindresorhus reviewed Jun 3, 2019
View reviewed changes
readme.md Outdated Show resolved Hide resolved
@LitoMore
Copy link
Contributor Author

LitoMore commented Jun 4, 2019

@sindresorhus Docs updated

sindresorhus
sindresorhus reviewed Jun 12, 2019
View reviewed changes
readme.md Outdated Show resolved Hide resolved
sindresorhus
sindresorhus reviewed Jun 12, 2019
View reviewed changes
readme.md Outdated Show resolved Hide resolved
sindresorhus
sindresorhus reviewed Jun 12, 2019
View reviewed changes
readme.md Outdated Show resolved Hide resolved
@sindresorhus
Copy link
Owner

The PR title needs to be updated to reflect the final behavior.

LitoMore and others added 2 commits June 12, 2019 13:19
@LitoMore LitoMore changed the title Disable version/help output when cli.input is present Only consider enabling autoHelp/autoVersion in case there is only one argument in process.argv Jun 12, 2019
@LitoMore
Copy link
Contributor Author

@sindresorhus Updated

@sindresorhus sindresorhus merged commit cd29865 into sindresorhus:master Jun 12, 2019
@sindresorhus
Copy link
Owner

Thanks :)

@LitoMore LitoMore deleted the prevent-built-in-output branch June 12, 2019 08:26
@snyk-bot snyk-bot mentioned this pull request Mar 8, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Mar 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Only show version/help when cli.input.length === 0 is true
2 participants
@LitoMore @sindresorhus