-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove flag's aliases from the flags
property
#108
Conversation
This PR add Example: const cli = m({
argv: ['-c', '-l'],
flags: {
coco: {
alias: 'c'
},
loco: {
alias: 'l'
}
}
});
console.log(cli.flags);
//=> { c: true, coco: true, l: true, loco: true }
console.log(cli.simpleFlags);
//=> { c: true, coco: true} |
|
||
return { | ||
input, | ||
flags, | ||
unnormalizedFlags, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still not sold on this name. I think we should try to come up with something shorter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've got unsortedFlags
, what do you thing about it 🤷♂️ ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really better. Let's just go with unnormalizedFlags
for now.
This also needs docs updates. |
Made the changes requested but still can't choose a name. Also updated in the doc, should I add more infos ? |
flags
property
This looks good now. Thank you :) |
Fixes #102, short-flags in the
cli.flags
are a bit messy