Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The browser tests were flaky due to the reason that the
server.close()
call was slow sometimes due to open connection kept alive, which is default server behaviour. Resulting in false pending tests assertiions that are actually finished but never finish and times out due to that the server is not closed within the expected timeout.What's done
beforeEach
andafterEach
methods that setups and closes server for each test.UntitledMacro
that has been renamed toImplementation
.NOTES:
beforeEach
andafterEach
methods that setups and closes the server. Unless done this way the browser tests keep beeing flaky 🤷🏽 .