feat: Support Dynamic Import in Webpack Context #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Webpack will try to bundle modules during compile time and replacing the original `require`, so using `require` directly in the Webpack context to load configs could result in `MODULE_NOT_FOUND` error. Switching to `__non_webpack_require__` to use plain `require` while in the Webpack environment. - Remove `.js` extension in `heapdump.js` to make `xo` happy - Update `tsd` to the latest to ignore `node_modules` folder
- Upgrade dependencies. parent-module is kept at 2.0.0 because 3.0.0 is pure ESM and require this package to be pure ESM, but this package is built based on the `require` (synchronous import) in CommonJS - Bump node version to be >= 18 to drop EOL versions.
This was referenced Jun 10, 2024
|
I think this is exactly what I am looking for, spent at least 8 hours debugging this :D I suspected it's worker threads but then found it's webpack! You are hero! going to try it now! EDIT: It did work! THANK YOU! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #21
Credit: Thanks @jeremiegirault for proposing the changes in #21
Description
Webpack will try to bundle modules during compile time and replace the original
require, so usingrequiredirectly in the Webpack context to load configs could result inMODULE_NOT_FOUNDerror. Switching to__non_webpack_require__to use plainrequirewhile in the Webpack environment.About
__non_webpack_require__:Try to solve issues like:
Test
npm run test