-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configured optional dependencies are not optional #221
Comments
Just found a related issue. |
Sure. PR welcome. Weird that it works with npm though. I've commented here how it should be implemented: #224 (comment) |
I'm actually having this with NPM as well. |
@sindresorhus how do you want to handle it? Just make them regular dependencies? |
Having the same problem here using NPM :( |
Same issue here. Seems to be gifsicle being the problem for me. Using NPM. |
These are required at `index.js` and thus should not be optional. Fixes sindresorhus#221
…tional and don't always get installed (fix coming soon sindresorhus/gulp-imagemin#221)
I am really baffled about this thread. Especially that @sindresorhus writes "Weird that it works with npm though." when this PR exists for month: #185 |
Installing
gulp-imagemin
usingyarn
fails - for some reason - to install the optional dependencies, which results in this error when runninggulp
:This happens probably because the optional dependencies are required nonetheless.
npm
's documentation states the following regarding optional dependencies:The text was updated successfully, but these errors were encountered: