-
-
Notifications
You must be signed in to change notification settings - Fork 72
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Upgrade to ESLint 8 and require Node.js 12 (#171)
- Loading branch information
Showing
5 changed files
with
56 additions
and
51 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,62 +1,67 @@ | ||
| 'use strict'; | ||
| const chalk = require('chalk'); | ||
| const eslint = require('eslint'); | ||
| const { ESLint } = require('eslint'); | ||
|
|
||
| module.exports = grunt => { | ||
| grunt.registerMultiTask('eslint', 'Validate files with ESLint', function () { | ||
| const options = this.options({ | ||
| outputFile: false, | ||
| quiet: false, | ||
| maxWarnings: -1, | ||
| failOnError: true, | ||
| }); | ||
|
|
||
| if (this.filesSrc.length === 0) { | ||
| grunt.log.writeln(chalk.magenta('Could not find any files to validate')); | ||
| return true; | ||
| } | ||
| grunt.registerMultiTask('eslint', 'Validate files with ESLint', async function () { | ||
| const done = this.async(); | ||
|
|
||
| const formatter = eslint.CLIEngine.getFormatter(options.format); | ||
| try { | ||
| const { format, quiet, maxWarnings, failOnError, outputFile, ...options } = this.options({ | ||
| outputFile: false, | ||
| quiet: false, | ||
| maxWarnings: -1, | ||
| failOnError: true, | ||
| format: "stylish" | ||
| }); | ||
|
|
||
| if (!formatter) { | ||
| grunt.warn(`Could not find formatter ${options.format}`); | ||
| return false; | ||
| } | ||
| if (this.filesSrc.length === 0) { | ||
| grunt.log.writeln(chalk.magenta('Could not find any files to validate')); | ||
| return true; | ||
| } | ||
|
|
||
| const engine = new eslint.CLIEngine(options); | ||
| const engine = new ESLint(options); | ||
|
|
||
| let report; | ||
| try { | ||
| report = engine.executeOnFiles(this.filesSrc); | ||
| } catch (error) { | ||
| grunt.warn(error); | ||
| return false; | ||
| } | ||
| const formatter = await engine.loadFormatter(format); | ||
|
|
||
| if (options.fix) { | ||
| eslint.CLIEngine.outputFixes(report); | ||
| } | ||
| if (!formatter) { | ||
| grunt.warn(`Could not find formatter ${format}`); | ||
| return false; | ||
| } | ||
|
|
||
| let results = report.results; | ||
| let results = await engine.lintFiles(this.filesSrc); | ||
|
|
||
| if (options.quiet) { | ||
| results = eslint.CLIEngine.getErrorResults(results); | ||
| } | ||
| if (options.fix) { | ||
| await ESLint.outputFixes(results); | ||
| } | ||
|
|
||
| const output = formatter(results); | ||
| if (quiet) { | ||
| results = ESLint.getErrorResults(results); | ||
| } | ||
|
|
||
| if (options.outputFile) { | ||
| grunt.file.write(options.outputFile, output); | ||
| } else if (output) { | ||
| console.log(output); | ||
| } | ||
| const output = formatter.format(results); | ||
|
|
||
| const tooManyWarnings = options.maxWarnings >= 0 && report.warningCount > options.maxWarnings; | ||
| if (outputFile) { | ||
| grunt.file.write(outputFile, output); | ||
| } else if (output) { | ||
| console.log(output); | ||
| } | ||
|
|
||
| if (report.errorCount === 0 && tooManyWarnings) { | ||
| grunt.warn(`ESLint found too many warnings (maximum: ${options.maxWarnings})`); | ||
| } | ||
| const { warningCount, errorCount } = results.reduce((count, { warningCount, errorCount }) => { | ||
| count.warningCount += warningCount; | ||
| count.errorCount += errorCount; | ||
| return count; | ||
| }, { warningCount: 0, errorCount: 0 }); | ||
|
|
||
| return options.failOnError ? report.errorCount === 0 : 0; | ||
| const tooManyWarnings = maxWarnings >= 0 && warningCount > maxWarnings; | ||
|
|
||
| if (errorCount === 0 && tooManyWarnings) { | ||
| grunt.warn(`ESLint found too many warnings (maximum: ${maxWarnings})`); | ||
| } | ||
|
|
||
| done(failOnError ? errorCount === 0 : 0); | ||
| } catch (err) { | ||
| done(err); | ||
| } | ||
| }); | ||
| }; | ||
| }; |