Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assure there are no timeout errors after got() has resolved #528

Merged
merged 1 commit into from
Jul 18, 2018
Merged

Assure there are no timeout errors after got() has resolved #528

merged 1 commit into from
Jul 18, 2018

Conversation

jstewmon
Copy link
Contributor

relates to #501

@jstewmon
Copy link
Contributor Author

Please hold on merging for a few minutes. I can figure out a test for the promise interface too.

@jstewmon
Copy link
Contributor Author

Ok, tests added for both interfaces

@szmarczak szmarczak changed the title test error not emitted when timeout is not breached Assure there are no timeout errors after got() has resolved Jul 18, 2018
@szmarczak szmarczak merged commit 13bb0fa into sindresorhus:master Jul 18, 2018
@jstewmon jstewmon deleted the timeout-ok-test branch July 18, 2018 18:44
@jstewmon
Copy link
Contributor Author

er... i neglected git add, so only one test was included. I'll open another PR

@jstewmon jstewmon mentioned this pull request Jul 18, 2018
Merged
sindresorhus pushed a commit that referenced this pull request Jul 18, 2018
@jstewmon @sindresorhus
Test that timeout error is not erroneously emitted using promise inte…
75fd8d3 
…rface (#529)

Relates to #528
@szmarczak szmarczak mentioned this pull request Jul 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szmarczak szmarczak szmarczak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jstewmon @szmarczak