Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check req.connection exists before attaching event listeners #429

Merged
merged 1 commit into from
Jan 9, 2018
Merged

Check req.connection exists before attaching event listeners #429

merged 1 commit into from
Jan 9, 2018

Conversation

lukechilds
Copy link
Contributor

@lukechilds lukechilds commented Nov 27, 2017 •
edited by sindresorhus
Loading

Fixes #427

Obviously progress events won't work in the browser, do we need to specify this in the readme?

@lukechilds lukechilds mentioned this pull request Nov 30, 2017
Closed
@sindresorhus sindresorhus mentioned this pull request Dec 29, 2017
Closed
@lukechilds
Copy link
Contributor Author

req.connection also sometimes appears to be missing in Node.js when Got is used with a proxy agent.

@sindresorhus sindresorhus merged commit 30c39bc into sindresorhus:master Jan 9, 2018
@szmarczak szmarczak mentioned this pull request Jul 16, 2018
Closed
4 tasks
@jstewmon jstewmon mentioned this pull request Jul 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukechilds @sindresorhus