Fix: allow invalid arguments to throw appropriate Error message #2367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vylpes
pushed a commit
to Vylpes/random-bunny
that referenced
this pull request
Sep 2, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [got](https://github.com/sindresorhus/got) | resolutions | minor | [`14.0.0` -> `14.4.2`](https://renovatebot.com/diffs/npm/got/14.0.0/14.4.2) | --- ### Release Notes <details> <summary>sindresorhus/got (got)</summary> ### [`v14.4.2`](https://github.com/sindresorhus/got/releases/tag/v14.4.2) [Compare Source](sindresorhus/got@v14.4.1...v14.4.2) - Fix handling of invalid arguments ([#​2367](sindresorhus/got#2367)) [`f44ef43`](sindresorhus/got@f44ef43) ### [`v14.4.1`](https://github.com/sindresorhus/got/releases/tag/v14.4.1) [Compare Source](sindresorhus/got@v14.4.0...v14.4.1) - Fix missing dependency [`dfc54d9`](sindresorhus/got@dfc54d9) ### [`v14.4.0`](https://github.com/sindresorhus/got/releases/tag/v14.4.0) [Compare Source](sindresorhus/got@v14.3.0...v14.4.0) - Improve TypeScript types with generic extend ([#​2353](sindresorhus/got#2353)) [`15ca4a0`](sindresorhus/got@15ca4a0) ### [`v14.3.0`](https://github.com/sindresorhus/got/releases/tag/v14.3.0) [Compare Source](sindresorhus/got@v14.2.1...v14.3.0) - Update dependencies [`dbab6c3`](sindresorhus/got@dbab6c3) ### [`v14.2.1`](https://github.com/sindresorhus/got/releases/tag/v14.2.1) [Compare Source](sindresorhus/got@v14.2.0...v14.2.1) - Fix error handling when UTF-8 decoding fails ([#​2336](sindresorhus/got#2336)) [`c81a611`](sindresorhus/got@c81a611) ### [`v14.2.0`](https://github.com/sindresorhus/got/releases/tag/v14.2.0) [Compare Source](sindresorhus/got@v14.1.0...v14.2.0) - Add `cause` property with the original error to `RequestError` ([#​2327](sindresorhus/got#2327)) [`4cbd01d`](sindresorhus/got@4cbd01d) ### [`v14.1.0`](https://github.com/sindresorhus/got/releases/tag/v14.1.0) [Compare Source](sindresorhus/got@v14.0.0...v14.1.0) - Allow typing the body of a `RequestError` response ([#​2325](sindresorhus/got#2325)) [`5e4f6ff`](sindresorhus/got@5e4f6ff) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjQzMS40IiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==--> Reviewed-on: https://git.vylpes.xyz/RabbitLabs/random-bunny/pulls/217 Reviewed-by: Vylpes <[email protected]> Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2366
When invalid arguments are passed to the
gotfunction such asfalse, thenew Options()returns undefined. But that option object is destructured without checking for it beingundefinedinside the got function.Checklist