Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify retryWithMergedOptions valid hooks #1832

Merged
merged 5 commits into from
Aug 10, 2021
Merged

Clarify retryWithMergedOptions valid hooks #1832

merged 5 commits into from
Aug 10, 2021

Conversation

PopGoesTheWza
Copy link
Contributor

Checklist

  • I have read the documentation.
  • I have included a pull request description of my changes.
  • I have included some tests.
  • If it's a new feature, I have included documentation updates in both the README and the types.

A follow-up from #1781

Copy link
Collaborator

@szmarczak szmarczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all afterResponse hooks will be skipped. Only those who have been already executed.

@sindresorhus
Copy link
Owner

You also need to update the TypeScript docs comment.

@szmarczak
Copy link
Collaborator

You also need to update the TypeScript docs comment.

I'll update them when Got 12 is about to be released (stable).

@PopGoesTheWza
Copy link
Contributor Author

I'll update them when Got 12 is about to be released (stable).

Should I revert the TS doc update then?

@szmarczak
Copy link
Collaborator

No, if it's in already then it's better to stay that way :)

documentation/9-hooks.md Outdated Show resolved Hide resolved
@PopGoesTheWza
Copy link
Contributor Author

I checked the source code and rephrased.

documentation/9-hooks.md Outdated Show resolved Hide resolved
@szmarczak szmarczak changed the title doc: clarify retryWithMergedOptions valid hooks Clarify retryWithMergedOptions valid hooks Aug 10, 2021
source/core/options.ts Outdated Show resolved Hide resolved
@PopGoesTheWza
Copy link
Contributor Author

Sorry. I was careless.

@szmarczak szmarczak merged commit 15c30ee into sindresorhus:main Aug 10, 2021
@szmarczak
Copy link
Collaborator

Thanks 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants