Downgrade Travis CI Node.js version to 14.9.0 #1454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
changed the title
|
Now that the commit "stream: simpler and faster Readable async iterator" has been reverted this PR should also be reverted. |
|
@Giotino We have to wait until it's released and available on Travis. |
As you can see here https://travis-ci.com/github/sindresorhus/got/jobs/383613035 |
sindresorhus
added a commit
that referenced
this pull request
Sep 11, 2020
This reverts commit 27470b5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to keep using Travis CI correctly v14.9.0 has been specified instead of v14 (latest available).
This is a temporary measure, a rollback of the commit "stream: simpler and faster Readable async iterator" which broke nearly everything in Got has been planned for the next Node.JS release (v14.10.1) nodejs/node#35137
I don't know if downgrading Node.JS for CI is the right thing to do, but I think it won't do any harm while waiting for some fix for v14.10.0.
@sindresorhus @szmarczak