Include invalid JSON body in ParseErrors (#1044)

sindresorhus · Jan 28, 2020 · 2813b73 · 2813b73
1 parent 7f71571
commit 2813b73
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/source/as-promise.ts b/source/as-promise.ts
@@ -83,14 +83,14 @@ export default function asPromise<T>(options: NormalizedOptions): CancelableRequ
 			try {
 				response.body = parseBody(body, options.responseType, options.encoding);
 			} catch (error) {
+				// Fall back to `utf8`
+				response.body = body.toString();
+
 				if (isOk()) {
 					const parseError = new ParseError(error, response, options);
 					emitError(parseError);
 					return;
 				}
-
-				// Fall back to `utf8`
-				response.body = body.toString();
 			}
 
 			try {

diff --git a/test/response-parse.ts b/test/response-parse.ts
@@ -128,6 +128,7 @@ test('parse errors have `response` property', withServer, async (t, server, got)
 	const error = await t.throwsAsync<ParseError>(got({responseType: 'json'}), {instanceOf: ParseError});
 
 	t.is(error.response.statusCode, 200);
+	t.is(error.response.body, '/');
 });
 
 test('sets correct headers', withServer, async (t, server, got) => {