Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for RW2 and RAF file types #221

Merged
merged 1 commit into from
Jun 12, 2019

Conversation

mceachen
Copy link
Contributor

@mceachen mceachen commented Jun 11, 2019

If you're adding support for a new file type, please follow the below steps:

  • One PR per file type (sorry, they're right next to each other).
  • Add a fixture file named fixture.<extension> to the fixture directory.
  • Add the file extension to the types array in test.js.
  • Add the file type detection logic to the index.js file.
  • Add the file extension to the FileType type in index.d.ts.
  • Add the file extension to the Supported file types section in the readme, in the format - [`<extension>`](URL) - Format name, for example, - [`png`](https://en.wikipedia.org/wiki/Portable_Network_Graphics) - Portable Network Graphics
  • Add the file extension to the keywords array in the package.json file.
  • Run $ npm test to ensure the tests pass.
  • Open a pull request with a title like Add support for Format, for example, Add support for PNG.
  • The pull request description should include a link to the official page of the file format or some other source. Also include a link to where you found the file type detection / magic bytes and the MIME type.

Fixes #218

@przemyslawpluta
Copy link

przemyslawpluta commented Jun 11, 2019

@mceachen thanks @sindresorhus can you review and merge when you have a minute. Thanks.

@sindresorhus sindresorhus changed the title Add support for RW2 and RAF file types. Fixes #218 Add support for RW2 and RAF file types Jun 12, 2019
@sindresorhus sindresorhus merged commit ee910d9 into sindresorhus:master Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Fujifilm RAF & Panasonic RW2 format
3 participants