Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream() may throw End-Of-Stream error #467

Closed
Borewit opened this issue Jul 20, 2021 · 1 comment · Fixed by #468
Closed

stream() may throw End-Of-Stream error #467

Borewit opened this issue Jul 20, 2021 · 1 comment · Fixed by #468
Assignees
@Borewit
Labels
bug

Comments

@Borewit
Copy link
Collaborator

Borewit commented Jul 20, 2021

Method stream() may throw End-Of-Stream error.

Working on #434, in which I make the sample-size configurable this became very easy reproachable by making the sample size smaller (e.g. 30 bytes) and running it against the fixture.

What the behavior should be, is that the file-type cannot be determined. The End-Of-Stream is an error which is kind of likely to happen as we the underlying mechanisms are running out out of data due to the sample length limitation.
@Borewit Borewit added the bug label Jul 20, 2021
@Borewit Borewit self-assigned this Jul 20, 2021
Borewit added a commit that referenced this issue Jul 20, 2021
@Borewit
Prevent End-Of-Stream error in stream()
e4b6228 
Suppress the End-Of-Stream, instead assign `undefined` to `stream.fileType`.

Fix: #467
@Borewit Borewit mentioned this issue Jul 20, 2021
Merged
@Borewit Borewit linked a pull request Jul 22, 2021 that will close this issue
Prevent End-Of-Stream error in stream() #468
Merged
@Borewit
Copy link
Collaborator Author

Borewit commented Jul 22, 2021

Fixed by #468

@Borewit Borewit closed this as completed Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Borewit Borewit

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent End-Of-Stream error in stream() sindresorhus/file-type
1 participant
@Borewit