Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate replaceSymbols() method #77

Merged
merged 1 commit into from
Jul 1, 2021
Merged

Separate replaceSymbols() method #77

merged 1 commit into from
Jul 1, 2021

Conversation

ehmicky
Copy link
Collaborator

@ehmicky ehmicky commented Jun 30, 2021 •
edited
Loading

This PR addresses part of #50.

This separates the main function to a named export instead of merged to the main/default export.

In two follow-up PRs, I will also:

  • Drop Node.js <12 support
  • Move from CommonJS to ES modules. When doing so, this module will have both a default export and several named exports (replaceSymbols(), main and windows).

@sindresorhus
Copy link
Owner

main and windows

These names seem too generic for named exports. Maybe mainSymbols and windowsSymbols or something.

@sindresorhus sindresorhus merged commit 5aa4c62 into main Jul 1, 2021
@sindresorhus sindresorhus deleted the feat/separate-export branch July 1, 2021 04:58
@ehmicky ehmicky mentioned this pull request Jul 1, 2021
Merged
@ehmicky
Copy link
Collaborator Author

ehmicky commented Jul 1, 2021

Done in #78 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ehmicky @sindresorhus