Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve typing of stdio option #943

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Improve typing of stdio option #943

merged 1 commit into from
Apr 1, 2024

Conversation

ehmicky
Copy link
Collaborator

@ehmicky ehmicky commented Apr 1, 2024

This PR improves the types of the std* options

  • Improve stdin: iterable type
  • Only allow passing Uint8Array to stdin or stdio[0] not to stdio[3]
  • Better typing of array of values like {stdout: [...]}
  • Fix some missing readonly keywords
  • Simplification of some types
  • Add more type tests

@sindresorhus sindresorhus merged commit 5842e34 into main Apr 1, 2024
14 checks passed
@sindresorhus sindresorhus deleted the stdio-option-type branch April 1, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants