Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about graceful termination #562

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Conversation

mifi
Copy link
Contributor

@mifi mifi commented Jul 11, 2023

doesn't work on Windows

doesn't work on Windows
@ehmicky
Copy link
Collaborator

ehmicky commented Jul 11, 2023

Hi @mifi and thanks for this PR.

This looks good to me, except you would need to add the new documentation in the TypeScript comments too.

Same as the original [`child_process#kill()`](https://nodejs.org/api/child_process.html#child_process_subprocess_kill_signal), except if `signal` is `SIGTERM` (the default value) and the child process is not terminated after 5 seconds, force it by sending `SIGKILL`.

The CI is currently failing, but this is due to #563

Copy link
Collaborator

@ehmicky ehmicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, this looks good.
Just waiting on #563 to get merged, and @sindresorhus review on this PR.

@sindresorhus sindresorhus merged commit 7bc6eb4 into sindresorhus:main Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants